Add sticky event support #3513
Open
Add sticky event support #3513
+119
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
| } | ||
|
|
||
| // There was call membership events at some point in the timeline. | ||
| return timeline.getEvents().some( |
There was a problem hiding this comment.
There is no API to get the sticky events? Having the sticky key doesn't make the event sticky.
I am a bit lost with what this method is expecting to do
| } | ||
|
|
||
| // There was call membership events at some point in the timeline. | ||
| return timeline.getEvents().some( |
There was a problem hiding this comment.
What is this method exactly? Try some heuristic to see if a room is a call room? like type": "org.matrix.msc3417.call"?
Or if there might be an active call?
And now it is checking for possible past sticky events (but potentially not anymore sticky)?
I don't get what this doing and what for
Half-Shot
changed the title
Sorry failed to change the title 🤦 |
- use new js-sdk - use custom synapse - don't filter rooms by existing call state events Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Half-Shot
force-pushed
the
toger5/sticky-events-version
branch
from
eb586a5 to
6580555
Compare
… toger5/sticky-events-version
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the newly merged sticky event work. Largely this just adds a new setting to enable it when starting a call. Sticky events will always work if someone else on the call enables it.
Testing options
Netilify
homeserverurl parameter to link your custom homeserver (example:https://localhost:3000?homeserver=https%3A%2F%2Ftest.comencoding is of course needed)Locally
pull/download this PR/branch
start the docker dev env via
yarn backend(synapse, livekit sfu, nginx, jwt authorizationService...)(in a new terminal) start EC
yarn devNow it should "just work" to do calls on https://localhost:3000